render context fixes - #87
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses cases where render() may be called before a canvas/context is initialized by deferring the render until after _initCanvas() completes, reducing “no context” runtime errors during early lifecycle events.
Changes:
- Add
isRenderAfterInitCanvasflag to defer rendering until a canvas/context exists (ChartAreaLayer, ChartWidgetLayer). - Replace
console.log+return 0“no context” paths with a deferred-render flow (and silent early returns forclear()). - Update the bundled
dist/iguanachart.jsto reflect the source changes.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/scripts/lib/charting/01-2-chartarealayer.js | Defers overlay rendering until the canvas/context is initialized. |
| src/scripts/lib/charting/01-1-chartwidgetlayer.js | Defers widget rendering until the canvas/context is initialized; avoids noisy console logging. |
| dist/iguanachart.js | Built artifact updated with the same deferred-render logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+122
to
+125
| if (this.isRenderAfterInitCanvas) { | ||
| this.isRenderAfterInitCanvas = false; | ||
| this.render(); | ||
| } |
Comment on lines
+934
to
+937
| if (this.isRenderAfterInitCanvas) { | ||
| this.isRenderAfterInitCanvas = false; | ||
| this.render(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.